Support Prettier v3 #2947

sosukesuzuki · 2023-04-06T14:03:37Z

Run tests
Update the CHANGELOG.md with a summary of your changes

Supports Prettier v3. Failed tests are not related to this PR. It also fails in main.

src/PrettierEditService.ts

sosukesuzuki · 2023-04-06T14:52:36Z

I found the problem of not being able to read ESM format configuration files...

fisker · 2023-04-11T02:31:47Z

I found the problem of not being able to read ESM format configuration files...

Prettier issue?

sosukesuzuki · 2023-04-11T06:40:03Z

@fisker

Prettier issue?

Maybe No, and maybe it happens only with this test. When I actually ran it on VSCode, it worked fine.

sosukesuzuki · 2023-04-15T11:21:28Z

I have found it difficult to test the loading of the configuration file with the way prettier-vscode testing now.
Even when testing the v3 folder, the configuration file is resolved using resolveConfigFile in Prettier 2.8.7. This is probably not a problem for users. It is a problem specific to testing this repository.

We will need to find a better way to test this in the future, for now I think we are good to go.

src/PrettierEditService.ts

fisker

Lgtm.

fisker · 2023-04-15T19:20:04Z

This one didn't awaited https://github.com/sosukesuzuki/prettier-vscode/blob/ab1b4ecfa540c634ddf2b2faaba1a60ab0a9ec57/src/ModuleResolver.ts#L327

I reviewed on cellphone, please double check Prettier api calls.

Need change

fisker · 2023-04-15T19:26:34Z

And this https://github.com/sosukesuzuki/prettier-vscode/blob/ab1b4ecfa540c634ddf2b2faaba1a60ab0a9ec57/src/TemplateService.ts#L23

src/PrettierEditService.ts

ntotten · 2023-04-17T22:49:57Z

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to the "prettier-vscode" extension will be documented in thi

 <!-- Check [Keep a Changelog](https://keepachangelog.com/) for recommendations on how to structure this file. -->

+## [9.12.0]


This should be a major release. 10.0.0

Maybe we should release v10 after Prettier releases v3? This PR is not breaking anything, just add support for v3 alpha.

@ntotten I agree with fisker. If you too can agree with this, please merge and release.

Seems there is a release workflow. So I guess we can create a v9.12.0 tag to trigger release?

prettier-vscode/.github/workflows/main.yml

Lines 70 to 73 in 8bd9176

release:

runs-on: ubuntu-latest

needs: package

if: startsWith(github.ref, 'refs/tags/v')

But let's wait for ntotten to respond first.

ntotten · 2023-04-17T22:52:34Z

Let me know if you need help on the tests.

fisker · 2023-04-23T10:48:50Z

@sosukesuzuki You are right, even after I fix the import() error, it still can't load config and plugins.

sosukesuzuki · 2023-04-23T11:02:04Z

Oh... So we must find the way execute import expr in prettier vscode...

fisker · 2023-04-23T11:40:25Z

Maybe this will work? LinqLover/downstream-repository-mining@9f57b01

fisker · 2023-04-23T11:50:30Z

Change to

var prettierPromise = new Function("x", "return import(x)")("./index.mjs");

["ERROR" - 19:48:21] A dynamic import callback was not specified.
TypeError: A dynamic import callback was not specified.

sosukesuzuki · 2023-04-23T12:53:19Z

Our problem is maybe caused by vscode-loader (ref: microsoft/vscode#130367 (comment)).

It uses vm.Script (ref: https://github.com/microsoft/vscode-loader/blob/15c69659545fa41e3290a7ad060f2ceaaaef5fa1/src/loader.js#L859)

Or vscode/src/vs/loader.js ? https://github.com/microsoft/vscode/blob/main/src/vs/loader.js#L797

sosukesuzuki · 2023-04-23T13:12:03Z

This is my guess: the reason why ESLint's Flat Config works fine may be because it is the Language Server that is doing the dynamic import. The client may not be able to do dynamic imports.

sosukesuzuki · 2023-04-23T13:14:28Z

We may need to adopt that same architecture... Separating the server that runs Prettier and client reflects values to the editor.

fisker · 2023-04-23T13:57:51Z

I also found an issue seems related to esm linked to vscode iteration plan, but looks like not useful.

opral/monorepo#452

kachkaev · 2023-04-23T15:43:50Z

I tried VS Code Insiders, but it did not help:

["INFO" - 16:38:35] Extension Name: esbenp.prettier-vscode.
["INFO" - 16:38:35] Extension Version: 9.12.0.
["ERROR" - 16:38:37] Error handling text editor change
["ERROR" - 16:38:37] A dynamic import callback was not specified.
TypeError: A dynamic import callback was not specified.
	at new NodeError (node:internal/errors:387:5)
	at importModuleDynamicallyCallback (node:internal/process/esm_loader:39:9)
	at Object.<anonymous> (/path/to/project/node_modules/.pnpm/[email protected]/node_modules/prettier/index.cjs:647:23)
	at u._compile (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/loader.js:4:1271)
	at Module._extensions..js (node:internal/modules/cjs/loader:1243:10)
	at Module.load (node:internal/modules/cjs/loader:1058:32)
	at Module._load (node:internal/modules/cjs/loader:893:12)
	at f._load (node:electron/js2c/asar_bundle:2:13330)
	at b._load (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:124:29918)

VS Code Insiders
Version: 1.78.0-insider
Commit: b19017cea80b6157aa8214c984a70022e77526f2
Date: 2023-04-21T05:39:53.263Z (2 days ago)

sosukesuzuki · 2023-04-26T02:58:15Z

I think we need to change prettier-vscode to a client/server architecture like a eslint-vscode for releasing Prettier v3.

@ntotten @fisker What do you think? Do you have an alternative plan?

fisker · 2023-04-26T04:07:41Z

I don't have other plan.

sosukesuzuki · 2023-04-27T03:32:11Z

Starting April 29th, my university and work will have 9 days off, so I'll try to implement it there.

sosukesuzuki · 2023-05-13T16:40:58Z

I'm working on https://github.com/sosukesuzuki/prettier-language-server. It will still take time. This is a more difficult task than I thought.

liuxingbaoyu · 2023-06-03T16:41:55Z

Is it possible for us to start a subprocess to handle it?
This will be a bit slower, but it shouldn't affect much.

sosukesuzuki · 2023-06-03T16:43:36Z

Sorry, what do you mean?

liuxingbaoyu · 2023-06-03T16:45:06Z

microsoft/vscode#130367 (comment)
Like this one.
We start a new node process and run prettier inside it.

sosukesuzuki · 2023-06-03T16:47:17Z

Oh.. I'll try it later. thank you

liuxingbaoyu · 2023-06-03T16:53:36Z

A new discovery!
worker_threads in vscode is accessible. We can try to take advantage of it!

fisker · 2023-06-03T17:01:42Z

worker_threads doesn't support chdir, should be careful.

sosukesuzuki added 3 commits April 5, 2023 00:16

Modify to await the promise returned by format

089967b

Add tests for Prettier v3

d053576

Add CHANGELOG

a4bcffe

sosukesuzuki commented Apr 6, 2023

View reviewed changes

src/PrettierEditService.ts Outdated Show resolved Hide resolved

Fix test cases

387352c

Await Support info

024d3fe

sosukesuzuki added 5 commits April 15, 2023 19:36

Remove dynmic checking

b80302e

Fix tests

60a1611

Fix test fixtures

59777d7

Run fmt

31e3ffb

Remove foo.txt

ab1b4ec

sosukesuzuki requested a review from fisker April 15, 2023 11:21

fisker reviewed Apr 15, 2023

View reviewed changes

src/PrettierEditService.ts Outdated Show resolved Hide resolved

fisker previously approved these changes Apr 15, 2023

View reviewed changes

More await for Prettier API calls

e766ad3

fisker reviewed Apr 16, 2023

View reviewed changes

src/PrettierEditService.ts Outdated Show resolved Hide resolved

Address review

8de8bae

sosukesuzuki marked this pull request as ready for review April 16, 2023 08:08

auto-assign bot requested a review from ntotten April 16, 2023 08:08

auto-assign bot assigned ntotten Apr 16, 2023

fisker approved these changes Apr 16, 2023

View reviewed changes

ntotten approved these changes Apr 17, 2023

View reviewed changes

This comment was marked as off-topic.

Sign in to view

kachkaev mentioned this pull request Apr 23, 2023

Bundle actual cjs entry prettier/prettier#14746

Closed

4 tasks

merceyz mentioned this pull request Apr 26, 2023

fix(sdks): support Prettier v3 yarnpkg/berry#5411

Merged

3 tasks

berekuk mentioned this pull request Apr 26, 2023

Prettier plugin quantified-uncertainty/squiggle#1723

Merged

fisker mentioned this pull request Apr 27, 2023

Release v3 prettier/prettier#13142

Closed

23 tasks

liuxingbaoyu mentioned this pull request Jun 3, 2023

Use Prettier v3.0.0-alpha.12 babel/babel#15617

Merged

kachkaev mentioned this pull request Jun 10, 2023

A dynamic import callback was not specified prettier/prettier#14917

Closed

sosukesuzuki mentioned this pull request Jun 10, 2023

Run prettier instance in worker_threads #3016

Merged

2 tasks

boris-petrov mentioned this pull request Jul 7, 2023

A dynamic import callback was not specified #3007

Closed

idahogurl mentioned this pull request Dec 2, 2023

fix: use synckit to support Prettier 3 idahogurl/vs-code-prettier-eslint#199

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Prettier v3 #2947

Support Prettier v3 #2947

sosukesuzuki commented Apr 6, 2023 •

edited

Loading

sosukesuzuki commented Apr 6, 2023

fisker commented Apr 11, 2023

sosukesuzuki commented Apr 11, 2023

sosukesuzuki commented Apr 15, 2023

fisker left a comment

fisker commented Apr 15, 2023 •

edited

Loading

fisker commented Apr 15, 2023

ntotten Apr 17, 2023

fisker Apr 18, 2023

sosukesuzuki Apr 20, 2023

fisker Apr 20, 2023 •

edited

Loading

ntotten commented Apr 17, 2023

fisker commented Apr 23, 2023

sosukesuzuki commented Apr 23, 2023 •

edited

Loading

fisker commented Apr 23, 2023

fisker commented Apr 23, 2023

This comment was marked as off-topic.

This comment was marked as off-topic.

sosukesuzuki commented Apr 23, 2023 •

edited

Loading

sosukesuzuki commented Apr 23, 2023

sosukesuzuki commented Apr 23, 2023

fisker commented Apr 23, 2023

kachkaev commented Apr 23, 2023 •

edited

Loading

sosukesuzuki commented Apr 26, 2023

fisker commented Apr 26, 2023

sosukesuzuki commented Apr 27, 2023

sosukesuzuki commented May 13, 2023

liuxingbaoyu commented Jun 3, 2023

sosukesuzuki commented Jun 3, 2023

liuxingbaoyu commented Jun 3, 2023

sosukesuzuki commented Jun 3, 2023

liuxingbaoyu commented Jun 3, 2023

fisker commented Jun 3, 2023

		@@ -4,6 +4,10 @@ All notable changes to the "prettier-vscode" extension will be documented in thi

		<!-- Check [Keep a Changelog](https://keepachangelog.com/) for recommendations on how to structure this file. -->

		## [9.12.0]

	release:
	runs-on: ubuntu-latest
	needs: package
	if: startsWith(github.ref, 'refs/tags/v')

Support Prettier v3 #2947

Support Prettier v3 #2947

Conversation

sosukesuzuki commented Apr 6, 2023 • edited Loading

sosukesuzuki commented Apr 6, 2023

fisker commented Apr 11, 2023

sosukesuzuki commented Apr 11, 2023

sosukesuzuki commented Apr 15, 2023

fisker left a comment

Choose a reason for hiding this comment

fisker commented Apr 15, 2023 • edited Loading

fisker commented Apr 15, 2023

ntotten Apr 17, 2023

Choose a reason for hiding this comment

fisker Apr 18, 2023

Choose a reason for hiding this comment

sosukesuzuki Apr 20, 2023

Choose a reason for hiding this comment

fisker Apr 20, 2023 • edited Loading

Choose a reason for hiding this comment

ntotten commented Apr 17, 2023

fisker commented Apr 23, 2023

sosukesuzuki commented Apr 23, 2023 • edited Loading

fisker commented Apr 23, 2023

fisker commented Apr 23, 2023

This comment was marked as off-topic.

This comment was marked as off-topic.

sosukesuzuki commented Apr 23, 2023 • edited Loading

sosukesuzuki commented Apr 23, 2023

sosukesuzuki commented Apr 23, 2023

fisker commented Apr 23, 2023

kachkaev commented Apr 23, 2023 • edited Loading

sosukesuzuki commented Apr 26, 2023

fisker commented Apr 26, 2023

sosukesuzuki commented Apr 27, 2023

sosukesuzuki commented May 13, 2023

liuxingbaoyu commented Jun 3, 2023

sosukesuzuki commented Jun 3, 2023

liuxingbaoyu commented Jun 3, 2023

sosukesuzuki commented Jun 3, 2023

liuxingbaoyu commented Jun 3, 2023

fisker commented Jun 3, 2023

sosukesuzuki commented Apr 6, 2023 •

edited

Loading

fisker commented Apr 15, 2023 •

edited

Loading

fisker Apr 20, 2023 •

edited

Loading

sosukesuzuki commented Apr 23, 2023 •

edited

Loading

sosukesuzuki commented Apr 23, 2023 •

edited

Loading

kachkaev commented Apr 23, 2023 •

edited

Loading